Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-prompting rule as experimental #2093

Merged
merged 4 commits into from May 3, 2022

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented May 2, 2022

Adds a new experimental rule to disallow the use of vars_prompt or ansible.builtin.pause to better accommodate unattended playbook runs and use in CI pipelines.

This rule is opt-in for now and needs to be explicitly enabled to be used.

Fixes: #2036

@ziegenberg ziegenberg requested review from a team as code owners May 2, 2022 00:52
@ziegenberg ziegenberg force-pushed the add-disallow-prompting-rule branch 2 times, most recently from 0e427b1 to 73d0f33 Compare May 2, 2022 12:42
@ziegenberg
Copy link
Contributor Author

I can't get the test to work. It somehow does not include the error from the matchplay-call 🤷🏻‍♂️
Any help is appreciated.

@ssbarnea ssbarnea changed the title add no-prompting rule Add no-prompting rule (experimental) May 3, 2022
@ssbarnea ssbarnea changed the title Add no-prompting rule (experimental) Add no-prompting rule as experimental May 3, 2022
Adds a new experimental rule to disallow the use of `vars_prompt` or
`ansible.builtin.pause` to better accommodate unattended playbook
runs and use in CI pipelines.

This rule is opt-in for now and needs to be explicitly enabled to be
used.

Fixes: ansible#2036

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the add-disallow-prompting-rule branch from d5766b4 to f41e000 Compare May 3, 2022 10:04
@ziegenberg
Copy link
Contributor Author

I rebased and fixed PYTEST_REQPASS: 610 in the tox GHA workflow.

@ssbarnea ssbarnea requested a review from cidrblock May 3, 2022 11:35
@ssbarnea ssbarnea merged commit cae94a8 into ansible:main May 3, 2022
@ziegenberg ziegenberg deleted the add-disallow-prompting-rule branch May 3, 2022 11:35
@cidrblock
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule request: Disallow prompting in playbooks
3 participants