Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise name[play] for plays missing a name #2295

Merged
merged 1 commit into from Aug 22, 2022
Merged

Raise name[play] for plays missing a name #2295

merged 1 commit into from Aug 22, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 14, 2022 •
edited

From now on, we will be require plays to have names, same as tasks, as these are also displayed by Ansible and help documenting their purpose.

Related: #2171

@ssbarnea ssbarnea requested review from a team as code owners August 14, 2022 13:16
@github-actions github-actions bot added the bug label Aug 14, 2022
cognifloyd
cognifloyd reviewed Aug 14, 2022
View reviewed changes
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Aug 16, 2022
@ssbarnea
Prepare fixtures for upcoming name[play] rule
4dc4edf 
Related: ansible#2295
@ssbarnea ssbarnea mentioned this pull request Aug 16, 2022
Merged
@ssbarnea ssbarnea changed the title Update name[missing] to trigger on plays too Add name[play] rule that checks for names on plays Aug 16, 2022
@ssbarnea ssbarnea marked this pull request as draft August 16, 2022 13:55
ssbarnea added a commit that referenced this pull request Aug 16, 2022
@ssbarnea
Prepare fixtures for upcoming name[play] rule (#2302)
603bf4d 
Related: #2295
@ssbarnea ssbarnea force-pushed the fix/kinds branch 2 times, most recently from 79c67ad to 0be4238 Compare August 17, 2022 17:00
@ssbarnea ssbarnea removed the bug label Aug 17, 2022
@github-actions github-actions bot added the bug label Aug 17, 2022
@ssbarnea ssbarnea marked this pull request as ready for review August 17, 2022 17:11
@ssbarnea ssbarnea removed the bug label Aug 17, 2022
cognifloyd
cognifloyd reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few more nitpicks.

src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
src/ansiblelint/rules/name.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the bug label Aug 22, 2022
@ssbarnea
Add name[play] to highlight plays without name
ae9f0d5 
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
hswong3i added a commit to alvistack/docker-gitlab-ce that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
f4533d6
hswong3i added a commit to alvistack/docker-gitlab-ee that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
132be46
hswong3i added a commit to alvistack/docker-golang that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
894ae69
hswong3i added a commit to alvistack/docker-fisheye that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
dd3fc4f
hswong3i added a commit to alvistack/docker-httpd that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
2219100
hswong3i added a commit to alvistack/docker-jira that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
fa96522
hswong3i added a commit to alvistack/docker-mariadb that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
e18a472
hswong3i added a commit to alvistack/docker-mitmproxy that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
a81ea86
hswong3i added a commit to alvistack/docker-node that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
5406557
hswong3i added a commit to alvistack/docker-devel that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
c666c4b
hswong3i added a commit to alvistack/docker-openjdk that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
22c4882
hswong3i added a commit to alvistack/docker-opensuse that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
cf58cb5
hswong3i added a commit to alvistack/docker-python that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
52f4c9b
hswong3i added a commit to alvistack/docker-postfix that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
2d057b7
hswong3i added a commit to alvistack/docker-php-fpm that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
bbc74c6
hswong3i added a commit to alvistack/docker-postgres that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
9930de6
hswong3i added a commit to alvistack/docker-gitlab-runner that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
3dc9f2f
hswong3i added a commit to alvistack/docker-rhel that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
79d1267
hswong3i added a commit to alvistack/docker-ubuntu that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
a3f7772
hswong3i added a commit to alvistack/ansible-collection-kubernetes that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
9ece0c3
hswong3i added a commit to alvistack/vagrant-centos that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
90f63b2
hswong3i added a commit to alvistack/vagrant-debian that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
8f53742
hswong3i added a commit to alvistack/vagrant-fedora that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
362be29
hswong3i added a commit to alvistack/vagrant-opensuse that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
cd09f26
hswong3i added a commit to alvistack/vagrant-ceph that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
55b4ec8
hswong3i added a commit to alvistack/vagrant-rhel that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
03ead6b
hswong3i added a commit to alvistack/vagrant-ubuntu that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
d9c6b1c
hswong3i added a commit to alvistack/ansible-collection-gnome that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
2d35691
hswong3i added a commit to alvistack/vagrant-gitlab-runner that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
b11bc9e
hswong3i added a commit to alvistack/vagrant-kubernetes that referenced this pull request Aug 31, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2295
e3e3c4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@cidrblock cidrblock cidrblock approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ssbarnea @apatard @cognifloyd @cidrblock