Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-name: Name all plays and task blocks #2171

Closed
cidrblock opened this issue May 23, 2022 · 2 comments
Closed

no-name: Name all plays and task blocks #2171

cidrblock opened this issue May 23, 2022 · 2 comments
Assignees

Comments

@cidrblock
Copy link
Contributor

Starting to pull in possible rule ideas from the community of practice: redhat-cop/automation-good-practices#64

In #2169 it is suggested that all tasks have a name.

This extends that to cover plays and task blocks.

@cidrblock cidrblock added the new rule A request for a new rule label May 23, 2022
@ssbarnea ssbarnea added enhancement and removed new rule A request for a new rule labels Jul 19, 2022
@ssbarnea ssbarnea changed the title Rule request: Name all plays and task blocks no-name: Name all plays and task blocks Jul 19, 2022
@ssbarnea ssbarnea self-assigned this Jul 19, 2022
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 7, 2022
This reimplementation will allow us to implement closely related
extra checks.

Related: ansible#2171 ansible#2170 ansible#2169 ansible#2036
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 9, 2022
This reimplementation will allow us to implement closely related
extra checks.

Related: ansible#2171 ansible#2170 ansible#2169 ansible#2036
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 9, 2022
This reimplementation will allow us to implement closely related
extra checks.

Related: ansible#2171 ansible#2170 ansible#2169 ansible#2036
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 9, 2022
This reimplementation will allow us to implement closely related
extra checks.

Related: ansible#2171 ansible#2170 ansible#2169 ansible#2036
ssbarnea added a commit that referenced this issue Aug 9, 2022
This reimplementation will allow us to implement closely related
extra checks.

Related: #2171 #2170 #2169 #2036
@ssbarnea
Copy link
Member

@cidrblock Here are few things I found so far:

WDYT?

ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 14, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
@cidrblock
Copy link
Contributor Author

cidrblock commented Aug 15, 2022

IMHO, the name for an import playbook and block is equally important, it's unfortunate it doesn't show when the playbook is run, but when looking through the content to better understand what is going on and the original author's intent they can be really useful.

I find import_playbook and a block to be even more complex sometimes than a simple task (e.g. set_fact, debug) , so maybe it's even a little more important to have them here. I'm sure the "next developer" would appreciate the details, I would.

ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 16, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 16, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 17, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 17, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 17, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 22, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 22, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Aug 22, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: ansible#2171
ssbarnea added a commit that referenced this issue Aug 22, 2022
From now on, we will be require plays to have names, same as task,
as these are also displayed by Ansible and help documenting them.

Related: #2171
@ssbarnea ssbarnea closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants