Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform Ansible syntax checking on linted playbooks #787

Closed
ssbarnea opened this issue May 16, 2020 · 0 comments · Fixed by #950
Closed

Perform Ansible syntax checking on linted playbooks #787

ssbarnea opened this issue May 16, 2020 · 0 comments · Fixed by #950
Assignees
@ssbarnea
Labels
feature

Comments

@ssbarnea
Copy link
Member

ssbarnea commented May 16, 2020 •
edited

In order to include results from ansible --syntax-check we should make use of PlaybookExecutor.run() so users of the linter would not have to also run ansible check on the files.

A good start would be to identify a problem that is reported by ansible own syntax check but not by ansible-lint
@ssbarnea ssbarnea added priority/medium new Triage required labels May 16, 2020
ssbarnea added a commit that referenced this issue Aug 13, 2020
@ssbarnea
WIP: Run ansible syntax check before linting playbooks
1a35772 
Fixes issue where users feed task/var files to the linter when in
reality it accepts only playbooks and roles. The linter reported the
task files as playbooks but silently failed to lint them and passed.

From now, any argument that is of playbook type will generate specific
errors if ansible syntax-check fails to process it. If you still want
to use old behavior you can still add 902 to skiplist.

That is WIP and not working, please comment only on architectural parts and
ignore minor details (it will be cleaned after).

Fixes: #787
@ssbarnea ssbarnea mentioned this issue Aug 13, 2020
Merged
ssbarnea added a commit that referenced this issue Aug 13, 2020
@ssbarnea
WIP: Run ansible syntax check before linting playbooks
b494934 
Fixes issue where users feed task/var files to the linter when in
reality it accepts only playbooks and roles. The linter reported the
task files as playbooks but silently failed to lint them and passed.

From now, any argument that is of playbook type will generate specific
errors if ansible syntax-check fails to process it. If you still want
to use old behavior you can still add 902 to skiplist.

That is WIP and not working, please comment only on architectural parts and
ignore minor details (it will be cleaned after).

Fixes: #787
ssbarnea added a commit that referenced this issue Aug 13, 2020
@ssbarnea
WIP: Run ansible syntax check before linting playbooks
86582cd 
Fixes issue where users feed task/var files to the linter when in
reality it accepts only playbooks and roles. The linter reported the
task files as playbooks but silently failed to lint them and passed.

From now, any argument that is of playbook type will generate specific
errors if ansible syntax-check fails to process it. If you still want
to use old behavior you can still add 902 to skiplist.

That is WIP and not working, please comment only on architectural parts and
ignore minor details (it will be cleaned after).

Fixes: #787
ssbarnea added a commit that referenced this issue Aug 13, 2020
@ssbarnea
WIP: Run ansible syntax check before linting playbooks
d633fed 
Fixes issue where users feed task/var files to the linter when in
reality it accepts only playbooks and roles. The linter reported the
task files as playbooks but silently failed to lint them and passed.

Fixes: #787
@ssbarnea ssbarnea self-assigned this Aug 13, 2020
@ssbarnea ssbarnea added this to the 4.3.0 milestone Aug 13, 2020
@ssbarnea ssbarnea changed the title feature: make use of PlaybookExecutor in order to include Ansible Syntax Check Perform Ansible syntax checking on linted playbooks Aug 13, 2020
@ssbarnea ssbarnea added feature and removed priority/medium new Triage required labels Aug 13, 2020
ssbarnea added a commit that referenced this issue Aug 14, 2020
@ssbarnea
WIP: Run ansible syntax check before linting playbooks
c05bd06 
Fixes issue where users feed task/var files to the linter when in
reality it accepts only playbooks and roles. The linter reported the
task files as playbooks but silently failed to lint them and passed.

Fixes: #787
@ssbarnea ssbarnea modified the milestones: 4.3.0, 4.3.1 Aug 16, 2020
ssbarnea added a commit that referenced this issue Dec 31, 2020
@ssbarnea
Added rule for ansible syntax check
3de0d96 
Fixes: #787
ssbarnea added a commit that referenced this issue Dec 31, 2020
@ssbarnea
Added rule for ansible syntax check
3d90e38 
Fixes: #787
ssbarnea added a commit that referenced this issue Dec 31, 2020
@ssbarnea
Added rule for ansible syntax check
94e3eb4 
Fixes: #787
ssbarnea added a commit that referenced this issue Dec 31, 2020
@ssbarnea
Added rule for ansible syntax check
c591d50 
Fixes: #787
ssbarnea added a commit that referenced this issue Dec 31, 2020
@ssbarnea
Added rule for ansible syntax check
0d65dcf 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 1, 2021
@ssbarnea
Added rule for ansible syntax check
1070012 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 4, 2021
@ssbarnea
Added rule for ansible syntax check
7083eab 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 4, 2021
@ssbarnea
Added rule for ansible syntax check
1daf39e 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 5, 2021
@ssbarnea
Added rule for ansible syntax check
d6dc0e1 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 5, 2021
@ssbarnea
Added rule for ansible syntax check
cf93bce 
Fixes: #787
ssbarnea added a commit that referenced this issue Jan 6, 2021
@ssbarnea
Added rule for ansible syntax check (#950)
83436b7 
Fixes: #787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

E911: Added AnsibleSyntaxCheckRule for running ansible syntax check ansible/ansible-lint
1 participant
@ssbarnea