Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pre-run errors when role-name is disabled #1459

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 11, 2021

  • when role-name is added to skip_list, just install simple role name
  • when role-name is added to warn_list, display warning and continue execution.
  • role-name rule is now moved to default warn_list, so users that do not have custom warn list, will only see its reported violations but the linter will report success.

Fixes: #1454

@ssbarnea ssbarnea added the feedback-needed Divergent oppinions, additional feedback is desired in order to unblock it. label Mar 11, 2021
- when `role-name` is added to skip_list, just install simple role name
- when `role-name` is added to warn_list, display warning and continue
  execution.

Fixes: #1454
@ssbarnea ssbarnea removed the feedback-needed Divergent oppinions, additional feedback is desired in order to unblock it. label Mar 11, 2021
Copy link

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@awcrosby awcrosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like what was discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

role_name check is not skipped when autodetecting standalone role name
3 participants