Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one false positive on pipe-fail rule #1477

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Remove one false positive on pipe-fail rule #1477

merged 1 commit into from
Mar 18, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 18, 2021

Avoid triggering the rule if pipefail string is used anywhere inside the script instead of only the first line. We can assume user knew what to do if it used pipefail inside.

Fixes: #663

@ssbarnea ssbarnea added the bug label Mar 18, 2021
Avoid triggering the rule if pipefail string is used anywhere inside
the script instead of only the first line. We can assume user knew
what to do if it used it.

Fixes: #663
@ssbarnea ssbarnea added this to the 5.0.5 milestone Mar 18, 2021
@ssbarnea ssbarnea merged commit 470e3c5 into master Mar 18, 2021
@ssbarnea ssbarnea deleted the 0/more branch March 18, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[306] set -o pipefail not detected unless it is the first line of the shell command
1 participant