Add opt-in rule to check whether FQCN is used for builtins #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an ansible module that was used
…le is never ignored
tadeboro
suggested changes
Jun 7, 2021
There was a problem hiding this comment.
I like the rule (for the playbooks I help maintain, we use FQCNs in all tasks). But this rule should definitely be disabled by default because as far as I know, there is no plan to deprecate bare name usage.
I did add a few nitpicks, but apart from that, the rule looks good to me.
|
Thanks for your review @tadeboro, I adapted the code to include your comments |
tadeboro
approved these changes
Jun 7, 2021
felixfontein
reviewed
Jun 7, 2021
Co-authored-by: Felix Fontein <felix@fontein.de>
tadeboro
approved these changes
Jun 7, 2021
felixfontein
approved these changes
Jun 7, 2021
ssbarnea
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have written in #1587, we currently have a regression for our custom rule that checks whether FQCNs are used everywhere.
As @ssbarnea suggested there, I added this rule upstream and made it opt-in. To not break current pipelines, it is by default turned off in the CI. I needed to change the
rule_runnerfixture, such that this rule is ran for therule_runnernevertheless (this also seems like the more sensible default to me, as you include a specific rule there and expect it to be run).This is my first contribution to this project, so feedback is welcome