Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Lintables to be modified #1884

Merged
merged 17 commits into from
Feb 16, 2022
Merged

Enable Lintables to be modified #1884

merged 17 commits into from
Feb 16, 2022

Commits on Feb 14, 2022

  1. Add Lintable.writable stream to handle updating files 

    The Lintable could represent a new file or it could be updating an existing file.
Either way, this allows us to detect file updates.
And it allows us (in the future) to provide some kind of diff-style output for those changes.
    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    63aad50 View commit details
    Browse the repository at this point in the history

  2. Add test for Lintable.updated

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    0e8049e View commit details
    Browse the repository at this point in the history

  3. Split writable test into more distinct tests

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    01d44b5 View commit details
    Browse the repository at this point in the history

  4. Add tests for Lintable.write

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    9cbc886 View commit details
    Browse the repository at this point in the history

  5. Cleanup Lintable tests

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    398046b View commit details
    Browse the repository at this point in the history

  6. Ensure Lintable.write() does not changed Lintable.updated

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a984efb View commit details
    Browse the repository at this point in the history

  7. Fix test mtime race condition

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    415a24f View commit details
    Browse the repository at this point in the history

  8. add Lintable.content setter to replace writable

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    e79e44a View commit details
    Browse the repository at this point in the history

  9. Drop Lintable.writable

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    784fe7a View commit details
    Browse the repository at this point in the history

  10. Drop more Lintable.writable references

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    ba76a0f View commit details
    Browse the repository at this point in the history

  11. Trigger re-reading Lintable by resetting content cache

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    35b0c7d View commit details
    Browse the repository at this point in the history

  12. Update Lintable.write docstring

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    06147ec View commit details
    Browse the repository at this point in the history

  13. Use _original_content != value to calculate Lintable.updated

    @cognifloyd
    cognifloyd committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    d87a6d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Load original_content from disk if needed to calculate updated

    @cognifloyd
    cognifloyd committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    9482195 View commit details
    Browse the repository at this point in the history

  2. Use a method to populate lintable content cache

    @cognifloyd
    cognifloyd committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    f544f32 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Merge branch 'main' into writables

    @ssbarnea
    ssbarnea committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    d98cf31 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into writables

    @ssbarnea
    ssbarnea committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    88da8d8 View commit details
    Browse the repository at this point in the history