Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib methods instead of open() in Lintable #1913

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Use pathlib methods instead of open() in Lintable #1913

merged 4 commits into from
Feb 17, 2022

Conversation

cognifloyd
Copy link
Contributor

This implements @webknjaz's suggestion in #1884 (comment)

@cognifloyd cognifloyd requested a review from a team as a code owner February 16, 2022 21:26
@cognifloyd cognifloyd added the skip-changelog Can be missed from the changelog. label Feb 16, 2022
@cognifloyd cognifloyd requested review from ssbarnea and webknjaz and removed request for a team February 16, 2022 21:26
@cognifloyd cognifloyd mentioned this pull request Feb 16, 2022
Merged
@cognifloyd cognifloyd changed the title Use pathlib's open() method in Lintable Use pathlib methods instead of open() in Lintable Feb 16, 2022
@cognifloyd cognifloyd self-assigned this Feb 16, 2022
@ssbarnea ssbarnea merged commit b4d2e4c into ansible:main Feb 17, 2022
@ssbarnea ssbarnea mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees

@cognifloyd cognifloyd

Labels
skip-changelog Can be missed from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cognifloyd @ssbarnea