Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta-no-info rule due to being covered by schema[meta] #3267

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ssbarnea
Copy link
Member

As our schema validation covers all the tests from meta-no-info,
it makes no sense to keep the rule.

@ssbarnea ssbarnea requested review from a team as code owners April 11, 2023 16:15
@ssbarnea ssbarnea added the bug label Apr 11, 2023
@ssbarnea ssbarnea force-pushed the fix/rule-consolidation branch 2 times, most recently from 2d0071e to 4f2d80e Compare April 11, 2023 16:36
As our schema validation covers all the tests from meta-no-info,
it makes no sense to keep the rule.
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, less code

@ssbarnea ssbarnea merged commit 2a787ab into main Apr 12, 2023
17 checks passed
@ssbarnea ssbarnea deleted the fix/rule-consolidation branch April 12, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants