Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rocky #3843

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Add support for Rocky #3843

merged 4 commits into from
Oct 17, 2023

Conversation

facorazza
Copy link
Contributor

No description provided.

@facorazza facorazza requested a review from a team as a code owner October 16, 2023 07:49
@facorazza facorazza requested review from a team, cristianonicolai and audgirka and removed request for a team October 16, 2023 07:49
@facorazza facorazza temporarily deployed to ack October 16, 2023 07:49 — with GitHub Actions Inactive
@facorazza facorazza temporarily deployed to ack October 16, 2023 07:57 — with GitHub Actions Inactive
@ssbarnea
Copy link
Member

@facorazza Have you checked how Ansible itself does recognize the platform? My impression is that it will be recognized as CentOS Linux, so this change would not be needed.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my tests with Rocky 8, the distribution name is Rocky, not RockyLinux.

 ansible localhost -m setup|grep distr
[WARNING]: No inventory was parsed, only implicit localhost is available
        "ansible_distribution": "Rocky",

@facorazza
Copy link
Contributor Author

Based on my tests with Rocky 8, the distribution name is Rocky, not RockyLinux.

 ansible localhost -m setup|grep distr
[WARNING]: No inventory was parsed, only implicit localhost is available
        "ansible_distribution": "Rocky",

Is it enough to change properties > name > const to Rocky?

@facorazza facorazza temporarily deployed to ack October 16, 2023 13:52 — with GitHub Actions Inactive
@facorazza facorazza temporarily deployed to ack October 16, 2023 14:05 — with GitHub Actions Inactive
@ssbarnea ssbarnea changed the title Add support for RockyLinux Add support for Rocky Oct 17, 2023
@ssbarnea ssbarnea added the bug label Oct 17, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 17, 2023 15:31 — with GitHub Actions Inactive
@ssbarnea ssbarnea merged commit 031038e into ansible:main Oct 17, 2023
23 checks passed
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 20, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | minor | `==6.20.3` -> `==6.21.1` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.21.1`](https://github.com/ansible/ansible-lint/releases/tag/v6.21.1)

[Compare Source](ansible/ansible-lint@v6.21.0...v6.21.1)

#### Bugfixes

-   Avoid exception caused by accidental unloading of core rules ([#&#8203;3857](ansible/ansible-lint#3857)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Document pre-commit access to ansible community bundle ([#&#8203;3856](ansible/ansible-lint#3856)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Fix bug with auto-fix ending too soon ([#&#8203;3855](ansible/ansible-lint#3855)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

### [`v6.21.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.21.0)

[Compare Source](ansible/ansible-lint@v6.20.3...v6.21.0)

#### Minor Changes

-   Allow linting plugin EXAMPLES as playbooks ([#&#8203;3309](ansible/ansible-lint#3309)) [@&#8203;Qalthos](https://github.com/Qalthos)

#### Bugfixes

-   Add support for Rocky ([#&#8203;3843](ansible/ansible-lint#3843)) [@&#8203;facorazza](https://github.com/facorazza)
-   Update supported Ubuntu versions in `meta.json` ([#&#8203;3845](ansible/ansible-lint#3845)) [@&#8203;mcdonnnj](https://github.com/mcdonnnj)
-   Avoid false positives for handler in roles handlers directory ([#&#8203;3838](ansible/ansible-lint#3838)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Hide stacktrace when loading invalid yaml ([#&#8203;3844](ansible/ansible-lint#3844)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Add some platforms to `meta.json` ([#&#8203;3841](ansible/ansible-lint#3841)) [@&#8203;mcdonnnj](https://github.com/mcdonnnj)
-   Temporary avoid auto-fixing YAML files not owned by ansible ([#&#8203;3837](ansible/ansible-lint#3837)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Add environment variable for skipping schema update ([#&#8203;3835](ansible/ansible-lint#3835)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Avoid creating temporary YAML files inside source tree ([#&#8203;3819](ansible/ansible-lint#3819)) [@&#8203;Qalthos](https://github.com/Qalthos)
-   Document environment variables ([#&#8203;3833](ansible/ansible-lint#3833)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Update schemas ([#&#8203;3832](ansible/ansible-lint#3832)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Support complex requirements in argument_specs.yml ([#&#8203;3823](ansible/ansible-lint#3823)) [@&#8203;tapetersen](https://github.com/tapetersen)
-   Fix SARIF-formatter severity levels ([#&#8203;3824](ansible/ansible-lint#3824)) [@&#8203;4ch1m](https://github.com/4ch1m)
-   Add play level autofix for key-order rule ([#&#8203;3815](ansible/ansible-lint#3815)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Add support for python 3.12 ([#&#8203;3813](ansible/ansible-lint#3813)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Update SPDX license list ([#&#8203;3814](ansible/ansible-lint#3814)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Use checkout action in install docs ([#&#8203;3810](ansible/ansible-lint#3810)) [@&#8203;gma](https://github.com/gma)
-   Fix actions-tagger arguments ([#&#8203;3808](ansible/ansible-lint#3808)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/161
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants