Fix KeyError on key-order rule with blocks
#4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_get_path_to_task_in_nested_tasks_block()` seems to do the wrong thing under certain circumstances when lineno > next_task_ling_index. It seems like we should never want that anyway, so just skip the whole thing until there is not a later play that is earlier than lineno.
Qalthos
requested review from
ssbarnea and
priyamsahoo
and removed request for
a team
audgirka
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4091
_get_path_to_task_in_nested_tasks_block()seems to do the wrong thing under certain circumstances when lineno > next_task_line_index. It seems like we should never want that anyway, so just skip the whole thing until there is not a later play that is earlier than lineno.