Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PackageNotLatest rule #568

Closed
wants to merge 1 commit into from
Closed

Remove PackageNotLatest rule #568

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2019

Fixes #479 due to no response from original committer, and official Ansible documentation allows 'latest' as a valid state.

Fixes #479 due to no response from original committer, and official Ansible documentation allows 'latest' as a valid state.

Signed-off-by: evitalis <evitalis@users.noreply.github.com>
@ghost ghost mentioned this pull request Oct 24, 2019
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against removal of this rule as there are perfect valid reasons for it exist. On the other hand we could disable a rule by default or create different linting profiles.
Maybe we just need to advertise better how easy is to use noqa to confirm that this is your intended use.

@webknjaz
Copy link
Member

@evitalis ansible-lint has no relation to what Ansible Core Team recommends. In general, we don't try to dictate what are the practices/styles that you have to follow — you are free to do what's best for your use case.
ansible-lint has a lot of rules that an average Core Team member would disagree with and, as such, is not a source of the "officially advised rules for writing playbooks".
So think of it as some community-driven recommendations that don't necessarily reflect what the Core Team thinks. Meaning that these rules should be changed if the community agrees, not just because Ansible can execute what you wrote.

@ghost
Copy link
Author

ghost commented Jan 20, 2020

@webknjaz That makes sense but there are a number of people commenting on the open issue that they also agree this rule should be disabled or removed as well. Those are also users of ansible and ansible-lint unless there is a different community you are referring to?

@webknjaz
Copy link
Member

@evitalis to me it looks like a rather exceptional use-case. Environments should be pinned to use well-defined versions of software in order to be reproducible. Using latest is possible but users should understand that it's not something that will create the same env every time they run this module. So I think it's reasonable to expect them to use a # noqa comment there in order to explicitly mark that they know what they are doing.

@ghost
Copy link
Author

ghost commented Jan 20, 2020

Would it be worth this conversation being moved to the referenced issue to get additional feedback and community comments please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-evaluate E0010 - Package installs should not use latest
2 participants