Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

synchronize module "ssh_args" parameters is not documented #3370

Closed
berlic opened this issue Apr 6, 2016 · 10 comments
Closed

synchronize module "ssh_args" parameters is not documented #3370

berlic opened this issue Apr 6, 2016 · 10 comments

Comments

@berlic
Copy link
Contributor

berlic commented Apr 6, 2016

ISSUE TYPE
  • Documentation Report
COMPONENT NAME

synchronize module(action plugin)

ANSIBLE VERSION
ansible 2.0.0.2

and current devel

CONFIGURATION

standard

OS / ENVIRONMENT

Ubuntu 14.04

SUMMARY

Ability to use ssh_args parameter to add custom ssh options to rsync is not documented.

Example:

- name: sync and dont touch known_hosts
  synchronize: src=. dest=/sources ssh_args="-o UserKnownHostsFile=/dev/null"
@berlic
Copy link
Contributor Author

berlic commented Apr 6, 2016

ssh_args is the solution for:
#270
#483

@sivel
Copy link
Member

sivel commented Apr 6, 2016

ssh_args was purposefully not documented. It is an internally created argument, that is populated when use_ssh_args is supplied to the module. This is to pass on the ssh_args configuration from ansible.cfg.

@berlic
Copy link
Contributor Author

berlic commented Apr 6, 2016

Thanks for reply, @sivel !

In this case there is no documented way to prevent rsync from reading/writing known_hosts file.
Modifying ssh_args in ansible.cfg is discouraged by the docs, because it completely overwrites ansible default ssh arguments instead of appending it. Inventory parameter ansible_ssh_common_args is advised, which is ignored by synchronize module.

If setting ssh_args for synchronize module should be avoided, use_ssh_args must honor inventory parameters: ansible_ssh_common_args, ansible_sftp_extra_args, ansible_scp_extra_args, ansible_ssh_extra_args.

@sivel
Copy link
Member

sivel commented Apr 6, 2016

Yes, synchronize should be updated to cascade ssh_*args.

@sivel
Copy link
Member

sivel commented Apr 6, 2016

I've submitted ansible/ansible#15306 to address the lack of cascading the args configurations.

@berlic
Copy link
Contributor Author

berlic commented Apr 6, 2016

Thanks! Should I close the issue now?

@sivel
Copy link
Member

sivel commented Apr 6, 2016

It can remain open for right now, while the bug still exists.

@tima
Copy link
Contributor

tima commented Jul 30, 2016

Unless I'm missing something, I believe this issue can be closed now.

@ansibot
Copy link

ansibot commented Jul 31, 2016

@ansible, ping. This issue is still waiting on your response.
click here for bot help

@tima
Copy link
Contributor

tima commented Aug 1, 2016

bug_resolved

@ansibot ansibot closed this as completed Aug 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants