wait_for to ensure ELB has been removed from AWS

[Etherdaemon]

@jsdalton, @RickMendes
Hi Rick and Jim,

Can I propose the following pull request which will allow users to specify if they would like to wait to ensure the ELB (and the attached interface as it does silly things) has been removed from AWS?

I've had consistent situations where I cannot remove the security groups as a result of the ELB not technically registering as removed yet from AWS (Eventual Consistency issue).

In this PR I haven't exposed the possiblity for providing the max increment or polling time but that can be updated as well.

Karen

[gregdek]

Thanks @Etherdaemon. @jsdalton @RickMendes please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit' or 'needs_revision' as appropriate.

[ghost]

@Etherdaemon I like the idea of having this and I don't see any problems with the current changes.

To make it a full feature add, I would like to see it be more configurable. As such I am marking it as needs_revision.

As you suggest, you could offer users the chance to set max increment and polling time. I wonder if it would be better to simply offer a wait_time like many other modules do. Then you could just divide that time by your chosen number of increments to get your polling time. That also means every user does not need to know how your polling works.

This is just a code review. I don't have time this week to do any testing.

[Etherdaemon]

@RickMendes Thanks for the feedback. I'll work on a revision and resubmit later this week. Thanks again.

[gregdek]

Thanks @Etherdaemon for this PR. A maintainer of this module has asked for revisions to this PR. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

[Etherdaemon]

Hi @RickMendes and @gregdek.

ready_for_review

Thanks heaps.

[ghost]

@Etherdaemon Thanks for taking care of this. I believe it is time to shipit.

/cc @gregdek

[gregdek]

Thanks again to @Etherdaemon for this PR, and thanks @jsdalton @RickMendes for reviewing. Marking for inclusion.