ec2_vpc creating/updating incorrect subnets #2931
Conversation
|
Thanks @ryannealmes. @carsongee please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit' or 'needs_revision' as appropriate. |
|
@carsongee This change is still pending your review; do you have time to take a look and comment? Please comment with text 'shipit' or 'needs_revision' as appropriate. |
|
This looks good, the rename make things clearer, and I believe you are correct that we should only be doing the tag merge when the current VPC subnet matches the play subnet being processed. |
|
Will this fix be out in the wild soon? Our process just blew up after an Ansible upgrade... |
|
Thanks again to @ryannealmes for this PR, and thanks @carsongee for reviewing. Marking for inclusion. |
ec2_vpc creating/updating incorrect subnets
|
Any chance it can be retrofitted into 2.0.x branch and pushed to Ubuntu PPA? |
The code to create/update/delete resource tags on subnets was incorrectly indented. This lead to subnets being overwritten. I indented code so it only executes tag comparison for matching cidr values. I also updated the names of the variables used to something a little more descriptive.
Would love to extract all this into a methods, but my python is limited. Definitely going to skill up so I can give this module some love.
Linked issue:
#2930
Related commits:
f769305
Please be strict with the review ... I am not a python developer (not that the change was big or anything). There don't seem to be any tests and I don't want to be introducing any bugs.