Add "reloaded" state for supervisorctl module

[dellsystem]

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

supervisorctl

ANSIBLE VERSION

ansible 2.1.0.0

SUMMARY

Implements #3229 partially, by adding a "reloaded" state that uses the new "signal" command in supervisor 3.2.0 to send a SIGHUP signal.

Useful for gracefully reloading processes (e.g., celery workers with tasks that shouldn't be interrupted).

[gregdek]

Thanks @dellsystem. To the current maintainers, @mattupstate, @inetfuture please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

[jeffwidman]

The functionality of this PR is useful, and I'd like to see it merged.

However, can we use a different word than "reloaded"? In the supervisorctl context, supervisorctl reloaded means restart the entire supervisord daemon, not reload a single child process. So redefining it here in Ansible is confusing. I know we already redefine several supervisorctl commands, but IMHO we should have unique names when we're doing something different under the covers than what the supervisorctl docs indicate.

I have no idea what the right word is... perhaps "restart_using_sighup"?

[ansibot]

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

[ansibot]

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.