This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Fix git shallow update #3794
Merged
Fix git shallow update #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @robinro for this PR. This module is maintained by the Ansible core team, so it can take a while for patches to be reviewed. Thanks for your patience. Core team: please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with 'needs_revision' or merge as appropriate. [This message brought to you by your friendly Ansibull-bot.] |
robinro
force-pushed
the
fix-git-shallow-update
branch
from
d7d721a
to
9fa89cc
Compare
added 3 commits
June 6, 2016 10:27
fix ansible#3782, which was introduced by f1bacc1
fixes ansible#3782 git support for `--depth` did not fully work in old git versions (before 1.8.2) fall back to full clones/fetches on those versions
robinro
force-pushed
the
fix-git-shallow-update
branch
from
9fa89cc
to
77975f2
Compare
robinro
pushed a commit
to robinro/ansible
that referenced
this pull request
Jun 6, 2016
Older git versions don't treat the --depth option correctly. While the git module tried to work around this and introduced subtle bugs, ansible/ansible-modules-core#3794 falls back to full checkouts. Don't run the tests then.
This was referenced Jun 7, 2016
|
Merged to devel and stable-2.1 branches. |
abadger
pushed a commit
to ansible/ansible
that referenced
this pull request
Jun 9, 2016
* add git shallow fetch test covers ansible/ansible-modules-core#3782 updating a repo with depth=1 fails silently if version==HEAD * disable git shallow tests for old git versions Older git versions don't treat the --depth option correctly. While the git module tried to work around this and introduced subtle bugs, ansible/ansible-modules-core#3794 falls back to full checkouts. Don't run the tests then.
abadger
added a commit
that referenced
this pull request
Jun 9, 2016
abadger
added a commit
that referenced
this pull request
Jun 9, 2016
Waiting for fix from ronbinro to re-add https://app.shippable.com/runs/57599a7897ae890c00c2898d This reverts commit 063c56f.
|
@robinro -- Had to revert this because it broke integration tests. Want to take a look and then resubmit? (I'm back home from pycon now so feel free to ping me in IRC when it's ready.) |
Merged
abadger
pushed a commit
to abadger/ansible-modules-core
that referenced
this pull request
Jun 17, 2016
* remove unused variables * fetch branch name instead of HEAD fix ansible#3782, which was introduced by f1bacc1 * disable git depth option for old git versions fixes ansible#3782 git support for `--depth` did not fully work in old git versions (before 1.8.2) fall back to full clones/fetches on those versions
abadger
added a commit
to abadger/ansible-modules-core
that referenced
this pull request
Jun 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
source_control/git.py
ANSIBLE VERSION
devel
SUMMARY
Fix #3782, which was introduced by f1bacc1.
Fetch (updating a repo) failed silently when depth is given and version==HEAD.
This needs to be cherry-picked to 2.1-stable too since it break ansible-pull for people not specifying a version, i.e. the minimal example.