Be explicit about specifying the ssh port if it was user specified

[abadger]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

synchronize.py

ANSIBLE VERSION

devel

Probably affects all 2.x versions and possibly earlier

SUMMARY

Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.

Fixes #3895

[abadger]

@tima, @dvzubarev see if this fixes the problem for you.

Note -- I changed the documentation to match what the code was doing when the dest_port is unspecified. I didn't want to change the behaviour of the code too much because people might be relying on synchronize to pick up ssh client configuration when they didn't specify any port setting explicitly.

[gregdek]

Thanks @abadger. To the current maintainers, @tima please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

[tima]

Looks right to me based on what we discussed. @dvzubarev?

[gregdek]

Thanks @abadger for this PR. This module is maintained by the Ansible core team, so it can take a while for patches to be reviewed. Thanks for your patience.

Core team: please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with 'needs_revision' or merge as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

[tima]

@dvzubarev confirmed that this fixed the issue they reported in #3895.

shipit

[abadger]

Merged to devel and cherry-picked to the stable-2.1 branch