Fix #370

[mscherer]

Use the currently ignored and unused force parameters to explicitly say we want to push over a existing repository, following subversion convention. Fix issue #370

[abadger]

This looks good to me except for changing the default value of force. Not sure what to do there -- force is not currently used in combination with export so changing the default to no would keep the same behaviour for export. But force is currently used when updating an already existing repository. So if we changed the default value we could cause errors for some people.

Maybe we should change the default value and just document that the default has changed? (Both in the module documentation and the ansible/ansible/ Changelog file?)

What's your opinion?

[abadger]

This should also fix #388

[mscherer]

Indeed, didn't see force was used later in the code. So we could have a different default for each command ? It would be a bit hard to explain in the doc however.

[abadger]

I agree, that seems to be hard to document.

[justintaft]

+1 for leaving force to false for export.

If wanting to change the default value of force to true, add a warning message to the build process so people KNOW they should explicitly set the default, because it will change. Later on, make the actual change to true.

Alternatively, make the force field required in the future, and not have a default value.

For documentation

no for export, yes otherwise

isn't too confusing. It's better then breaking people's builds.

[abadger]

@mscherer: jimi-c, bcoca, and I talked it over and we're good to change the default of force to false as long as the change gets documented (so modify ChangeLog in the ansible/ansible repo to explain the effect on the subversion checkout functionality.) We'll try to review the other modules for the next major release and change other instances where force defaults to True to default to False as a safety measure as well.

[abadger]

Thanks @mscherer, I'vve merged this and will make sure the Changelog is updated.

Merged

Hi!

This has been merged in, and will also be included in the next major release.

If you or anyone else has any further questions, please let us know by stopping by one of the two mailing lists, as appropriate:

• https://groups.google.com/forum/#!forum/ansible-project - for user questions, tips, and tricks
• https://groups.google.com/forum/#!forum/ansible-devel - for strategy, future planning, and questions about writing code

Because this project is very active, we're unlikely to see comments made on closed tickets, but the mailing list is a great way to ask questions, or post if you don't think this particular
issue is resolved.

Thank you!