This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Do not require password when deleting os_user #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thingee
reviewed
Nov 14, 2016
| @@ -219,6 +215,10 @@ def main(): | |||
| domain_id = _get_domain_id(opcloud, domain) | |||
|
|
|||
| if state == 'present': | |||
| if update_password in ('always', 'on_create'): | |||
| if not password: | |||
| msg = ("update_password is %s but a password value is " | |||
There was a problem hiding this comment.
Lol, good catch, I was a bit too hurried this morning. I intended to use it in a fail_json call, which I have just done with a newer change set.
omgjlk
force-pushed
the
fix-update-password
branch
from
7425401
to
4ed91e0
Compare
|
Thanks @j2sol for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review. [This message brought to you by your friendly Ansibull-bot.] |
|
This build failure is due to a module outside of this PR. |
I broke backwards compat with the addition to define when a password should be updated. It was requiring that a password value be passed when deleting a user, which seems silly. This moves the argument logic out of the argument spec and into when it would be needed, when state is present.
omgjlk
force-pushed
the
fix-update-password
branch
from
4ed91e0
to
fe2cd56
Compare
|
Tested, looks good to me! |
dagwieers
pushed a commit
to dagwieers/ansible-modules-core
that referenced
this pull request
Nov 18, 2016
I broke backwards compat with the addition to define when a password should be updated. It was requiring that a password value be passed when deleting a user, which seems silly. This moves the argument logic out of the argument spec and into when it would be needed, when state is present.
sbussetti
pushed a commit
to sbussetti/ansible-modules-core
that referenced
this pull request
Nov 21, 2016
I broke backwards compat with the addition to define when a password should be updated. It was requiring that a password value be passed when deleting a user, which seems silly. This moves the argument logic out of the argument spec and into when it would be needed, when state is present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os_user
I broke backwards compat with the addition to define when a password
should be updated. It was requiring that a password value be passed when
deleting a user, which seems silly.
This moves the argument logic out of the argument spec and into when it
would be needed, when state is present.