This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Fixes #19030 -- Service module broken on Trusty #5865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the "check_systemd" function such that it now will attempt to read "/proc/1/comm" first and should the value of that output be "systemd" the function will return True. If the output of "/proc/1/comm" is "init" the function will return False. If "/proc/1/comm" does not exist the function will look for several canary files, ["/run/systemd/system/", "/dev/.run/systemd/", "/dev/.systemd/"] and return True if found. If neither "/proc/1/comm" reads "systemd", does not exist, and none of the canary files are found the function will return False. Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
|
This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible Please read through the repomerge page in the dev guide. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
service
ANSIBLE VERSION
SUMMARY
This change refactors the "check_systemd" function such that it now will
attempt to read "/proc/1/comm" first and should the value of that output
be "systemd" the function will return True. If the output of
"/proc/1/comm" is "init" the function will return False. If
"/proc/1/comm" does not exist the function will look for several canary
files, ["/run/systemd/system/", "/dev/.run/systemd/", "/dev/.systemd/"]
and return True if found. If "/proc/1/comm" does not read "systemd",
does not exist, and none of the canary files are found the function will
return False.
Closes Issue: ansible/ansible#19030
Signed-off-by: Kevin Carter kevin.carter@rackspace.com