Fix unchecked "application" attribute on Get-WebVirtualDirectory. #1354
Conversation
It always raise error if I specify "application" attribute, because "application" parameter is not passed on "Get-WebVirtualDirectory" function.
|
Thanks @mather. @WHenrik please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit' or 'needs_revision' as appropriate. |
|
@WHenrik This change is still pending your review; do you have time to take a look and comment? Please comment with text 'shipit' or 'needs_revision' as appropriate. |
|
@WHenrik still waiting on your review. Please comment with text 'shipit' or 'needs_revision' as appropriate. If we don't hear from you within 14 days, we will start to look for additional maintainers for this module. |
|
Assigning to @ansible/core review. Thanks for your patience @mather. |
| @@ -102,7 +102,12 @@ try { | |||
| $result.changed = $true | |||
| } | |||
|
|
|||
| $directory = Get-WebVirtualDirectory -Site $site -Name $name | |||
| $directory = if($application) { | |||
There was a problem hiding this comment.
This works, but can you follow the arg splat pattern used above on New-WebVirtualDirectory instead of repeating the command?
|
@mather A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. [This message brought to you by your friendly Ansibull-bot.] |
|
I have lost my testing environment for this PR. |
|
Thanks @mather. Unfortunately, we can't really put this into review until you can test. If you can't actually test the change you're proposing, I advise you to just close it. If you are able to test this change and it passes, then please comment "ready_for_review". Thanks. |
|
@mather A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer. [This message brought to you by your friendly Ansibull-bot.] |
|
Sorry, I can't follow this issue anymore. |
It always raise error if I specify "application" attribute, because "application" parameter is not passed on "Get-WebVirtualDirectory" function.