Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Elasticsearch add esusers module #1574

Closed

Conversation

barryib
Copy link
Contributor

@barryib barryib commented Jan 29, 2016

@gregdek
Copy link
Contributor

gregdek commented Jan 31, 2016

Thanks @barryib for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.

@morganchristiansson
Copy link

+1

@gregdek
Copy link
Contributor

gregdek commented May 4, 2016

Thanks @barryib for this PR. This PR requires revisions, either because it fails to build or by reviewer request. Please make the suggested revisions. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.

[This message brought to you by your friendly Ansibull-bot.]

- Update version to 2.2 to pass CI tests
- Use twitter contact into module description
@barryib barryib force-pushed the elasticsearch_add_esusers_module branch from 4825245 to 4c8f537 Compare May 5, 2016 07:23
@barryib
Copy link
Contributor Author

barryib commented May 5, 2016

Hello @gregdek,

It was because this pull request is becoming old. It's from January.
I've changed version from 2.1 to 2.2 to pass CI tests

@barryib
Copy link
Contributor Author

barryib commented May 5, 2016

ready_for_review

@gregdek
Copy link
Contributor

gregdek commented May 5, 2016

Thanks @barryib for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.

[This message brought to you by your friendly Ansibull-bot.]

@evgkrsk
Copy link

evgkrsk commented May 21, 2016

shipit

@barryib
Copy link
Contributor Author

barryib commented Jul 7, 2016

Hello,

I'm closing this PR in favor of #2528, which now support the shield API introduced by ES 2.3.

@evgkrsk @morganchristiansson thanks for your shipit comments on that new PR.

@barryib barryib closed this Jul 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants