Add mongodb parameter module

[nerzhul]

This module permit to configure mongodb live parameters to tune the running engine

[sivel]

This pull request has failed validation steps due to missing RETURN documentation. All new modules are required to add RETURN docs.

============================================================================
./database/misc/mongodb_parameter.py
============================================================================
ERROR: No RETURN provided

[nerzhul]

Fixed

[gregdek]

Thanks @nerzhul for this new module. When this module receives 'shipit' comments from two community members and any 'needs_revision' comments have been resolved, we will mark for inclusion.

[nerzhul]

@gregdek nobody wants to review it ? :)

[Lujeni]

imho, you should add the script condition see

if __name__ ==  '__main__':
    main()

[Lujeni]

@nerzhul imo, missing params to support the mongodb authentication (authenticate, mechanism), could be usefull to support all kind of mongodb platforms.

@gregdek imo, we need a unique way to manage the mongodb connection, each module try to re-implement it

[nerzhul]

@Lujeni i fixed the main call condition. Authentication is already okay, i import it from mongodb_user module. What is the problem then ?

[Lujeni]

The mongodb_user module doesn't support all necessary options like mechanism or ssl cert.

If we changed something in the mongodb_user module connection part, we need to re-check each mongodb modules, it's not dry. As i say in the previous comment, imo, we need a single way to manage the mongodb connection accross all mongodb module.

However, we can shipit this module 👍

[nerzhul]

Thanks @Lujeni :)
You are right. There is same problem on MySQL module in fact. If you have time to review #1593, don't hesitate

[nerzhul]

@Lujeni @gregdek can you update this PR status ?

[gregdek]

Will put into shipit for further review. Thanks @nerzhul!

[nerzhul]

Thanks @gregdek !

[resmo]

removed changed here, it is a common return. Only document the returns the module provides please.

[resmo]

This check can be removed after choices=['str', 'int']has been added, see comment above

[resmo]

I would like to merge it into 2.1 (freeze is today!) please update asap as commented :)

[nerzhul]

@resmo updated !
Tell me if it's good for you, then i will squash

[resmo]

add required=True to param and value

[resmo]

that was fast! no need to squash, github is able to squash commits natively :) the required=True are still missing IMHO

[nerzhul]

@resmo done :)

[resmo]

Thanks!

[nerzhul]

Thanks !