Conversation
- Decided to do a little more logic, to eliminate the extra method name - Does more path and variable checking to remove false positives of upload/download - Fixes an error that can occur with bad format JSON which has to do with an ending '\' which can potentially occur when users specify a local path.
To avoid confusion with the pre-existing S3 module, what do you think about writing smth in the documentation along the lines of: I would suggest to change Also, you should remove the automatic installation of the AWS SDK. This should instead raise an exception to the user and fail (similar to how the existing AWS modules work and error out when boto isn't detected). |
These are all good suggestions, I will work on updating the module when I get a chance in the next couple of days. Update: Also this module doesn't use |
…were provided, and also added overwrite param to explicitly specify whether to overwrite a file of the same name on the host machine. Thanks to @ryanwalls
Hi @schwartzmx I saw that you made some revisions here -- is this ready for re-review? |
20b1ae4
to
a456a2e
Compare
a456a2e
to
73ed61d
Compare
@gregdek sorry for the late reply, I had to make a couple minor changes, but this should be ready for re-review now. Thanks. |
Adding new process boilerplate. We will be evaluating all new module PRs according to this process, effective immediately. Thanks for submitting this new module to Ansible Extras! This module is now in community review, a process that is open to all Ansible users. In order for this module to be approved, it must gain the following votes: “works_for_me”: If you have tested the module thoroughly, including testing of all of the module’s options, and if the module works for you, please add “works_for_me” in the comments. “passes_guidelines”: If you have gone through the module guidelines and the module meets all of the requirements, please add “passes_guidelines” in the comments. Guidelines are available here: http://docs.ansible.com/developing_modules.html#module-checklist “needs_revision”: If the module fails to work for you, or if it doesn’t meet guidelines, please add “needs_revision” in the comments with details about what needs to be fixed. When a module has both “works_for_me” and “passes_guidelines” tags, we will promote the module for inclusion in Ansible Extras. At this point, you will be expected to maintain the module by fixing bugs and evaluating pull requests in a timely manner. Thanks again for submitting your Ansible module! |
Windows friends, please consider a review here: @trondhindenes @petemounce @elventear @smadam813 @jhawkesworth @angstwad @sivel @chrishoffman @cchurch |
Can't really comment on the functionality as I'm not an S3 user. Currently it doesn't meet the guidelines, but the PR actually pre-dates the guidelines so would have needed a crystal ball or similar to do so. To meet guidelines, I'd suggest... So its a needs_revision at the moment, but looks like it ought not to be lots of work to fix up. |
Thanks @jhawkesworth. @schwartzmx Please make the suggested revisions, and when you're done, please add a comment with the text "ready_for_review" and we will continue with the review process. Thanks! |
@schwartzmx A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. |
@schwartzmx Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If we don't hear from you within another 14 days, we will close this pull request. |
Closing due to contributor inactivity. |
win_s3
module:AWS_SDK
for PowerShellAWSPowerShell
module is not found on the machine, theAWS_SDK
tools will be downloaded and installed before continuing. Read more aboutAWS_SDK
: AWS-PowerShellCredentials:
access_key
andsecret_key
params to be used as the session's AWS Credentials. If these are not supplied, theAWS_SDK
will search the machine for configured credentials, either through IAM role, environment variables, or aws config file. Read more: Credentials-Search-OrderFunctions:
bucket
,key
, andlocal
file or directory.bucket
,key
, andlocal
file path or directory path. (Will be created on download)key
entered be a key-prefix, in other words not a full path to a file. Such asKey/Directory/To/Be/Downloaded/
as opposed toKey/To/Be/Downloaded.zip
.rm
param to remove thelocal
file or directory after upload.Params:
bucket
key
local
method
Supported
method
params:upload
download
Other params:
access_key
secret_key
rm
I tried to make the exception handling, and resultant error messages as informative and helpful as possible. If the error messages don't help solve the problem when testing, then it is most likely an authorization error for accessing a bucket/key with the machine credentials or specified credentials.
I believe there is room for more functionality in the future, but this does what I need it to do for the time being.
Questions, concerns, suggestions? Please let me know.
Phil