win_regedit; fixes dword changed error 2273, improved error handling; and adds example showing quotes around reg paths containing spaces following https://github.com/ansible/ansible-modules-extras/issues/2340

[jhawkesworth]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_regedit

ANSIBLE VERSION

ansible 2.2.0 (more-regedit-tests 0a0b44baeb) last updated 2016/06/16 06:13:34 (GMT +100)
  lib/ansible/modules/core: (detached HEAD 138430f116) last updated 2016/06/12 06:32:34 (GMT +100)
  lib/ansible/modules/extras: (regedit_fixes bc3e6e0e90) last updated 2016/06/16 06:21:00 (GMT +100)
  config file = 
  configured module search path = Default w/o overrides

SUMMARY

An earlier change I made broke change detection for dword registry data type, as reported in #2273. I think this fix should be preferred to #2273 as this one does not then break the binary registry data type change detection.

Also this PR adds a check to ensure the registry key is in the powershell ps-drive format following #2412
and replaces the ' .GetType().Name -eq ' comparisons with more idiomatic '-is' tests (following conversation with @nitzmahone

Also I added an example of managing a registry path that contains spaces, so that module users know to quote them in order to avoid failures when the module is re-run, following on from #2340 (which the issue creator has now closed).

I will create a separate PR for the integration tests that exercise the new behavior and link to this PR.

[jhawkesworth]

Integration tests for this change are in ansible/ansible#16319

[gregdek]

Thanks @jhawkesworth. To the current maintainers, @joshludwig, @smadam813 please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

[smadam813]

Good work @jhawkesworth! Tested locally and all seems well.

shipit