This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
pkgin: added check mode support, laid some groundwork for future `state=latest' support #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module.fail_json(msg="failed to remove %s: %s" % (package, out)) | ||
|
|
||
| remove_c += 1 | ||
|
|
||
| if remove_c > 0: | ||
|
|
||
| module.exit_json(changed=True, msg="removed %s package(s)" % remove_c) | ||
| module.exit_json(changed=True, msg=format_action_message(module, "removed", remove_c)) |
There was a problem hiding this comment.
why remove the information about # of packages?
never mind, it gets formatted in external function now
|
changes look good, could you squash the commits? |
|
@bcoca Sure thing. |
* Add support for check mode * Use "pkgin search" to guarantee 0 or 1 result * Edit documentation for style, new feature, etc. * General refactoring * Lay some groundwork for future support of "state=latest"
bcoca
added a commit
that referenced
this pull request
Mar 10, 2015
pkgin: added check mode support, laid some groundwork for future `state=latest' support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may be the first significant pull request I've made to any Python-based project, let alone Ansible. So please don't be shy about pointing out anything that violates Ansible or Python style.
Functionally, all this does is call
pkgin -n(answer "no" to everything) when check mode is in effect, instead ofpkgin -y. But I also tried to gussy up the messages in the output and to get the code prepared for adding in support forstate=latestanother time.Please note the "Known bug" that I described in the documentation block. This is not a bug I introduced, it's something that apparently has always been there due to the way pkgin works. I raised the issue in the pkgin project (see NetBSDfr/pkgin#42).