Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the :settings subcommand #1073

Merged
merged 8 commits into from Mar 11, 2022
Merged

Implement the :settings subcommand #1073

merged 8 commits into from Mar 11, 2022

Conversation

alisonlhart
Copy link
Collaborator

@alisonlhart alisonlhart commented Mar 10, 2022 •
edited by cidrblock

Fixes #577

Add settings action
Add settings subcommand

Peripheral changes included:

  • PresentableSettingsEntry becomes unfrozen as a frozen class cannot inherit from a frozen parent
  • PresentableSettingsEntry needs to inherit from ContentBase as will will be presented to the UI as is.
  • PresentableSettingsEntry loses it's get b/c `ContentBase has one
  • TypedStep now uses Sequence instead of List so a Tuple can be used
  • ui_framework.ui.show now recognizes both lists and tuples
  • serialize.ContentType can now be a List[ContentBase] b/c a run_stdout may be serializing a full list of entries
  • utils.serialize.prepare_content will now serialize a list of dataclasses

@cidrblock @alisonlhart
Settings - Commit Squash - signed off by alisonlhart, thedoubl3j, and…
94072dd 
… cidrblock

Steps in settings

Some Settings Changes

Adding additional menu columns and data

Removing an accidental change to config.py ui menu

Cleaning up menu columns, removing description and default_value columns

Added content heading and menu formatting

Fixing shorts showing as null

Cleanup

Starting settings file path work and refining settings stdout

Rebasing????

changes from monday

first pass on tests

Designing tests for settings action

Move into config subsystem

Refining tests for direct interactive ee and no ee tests

Formatting

Adding tests and fixing cli parameter issues in utils

Disable UPDATE_FIXTURES for settings tests

working on stdout test, WIP

fix doc string

test fixes and unit tests

Changing settings to use self._args instead of self.app.args

Linting changes

Additional docstring changes

update_fixtures to false to save CI

fixing stdout stuff

Linter changes

Update _yaml.py

Update _yaml.py

Update settings.py

Unneeded file

Unneeded file

Fixing tests and adding changelog fragment

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update fixtures to false

test fixes

settings unit test fixes (hopefully)

Squashed commit of the following:

commit 38c107f
Author: cidrblock <bthornto@redhat.com>
Date:   Thu Feb 17 10:24:11 2022 -0800

    Mask collection doc cache path

commit c63e830
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit 2ee93ee
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit fe30e46
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit cc3a675
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit e6a6ab3
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit f0fff09
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit 3fec8ae
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit c9c28e7
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

Presentation changes

Update unit tests

REmove curses

readding requirements.yml for builder test_ee

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

stdout test fixes and fixture updates after the last commit

Update docs/changelog-fragments.d/957.internal.md

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

Update docs/changelog-fragments.d/957.internal.md

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

formatting/docstring fixes

Test example for jake

isort

Add constants

Renaming changelog fragment and adding color constants to settings

Refactor utils

cut paste error

Utils updates and variable readability change

Settings updates

Rm commented code, move file

sort

Update definitions.py

Lint fixes, restore type aliases

Switch to TypedDict

Typeddict in 3.8

Format

cast again

TValueType :) all the way through

Switch to DataClass

Unit test fix

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Rebase and update

Fix stdout

Remove duplicate clear

Definitions constants update

Initial support for settings

Steps in settings

Some Settings Changes

Some Settings Changes

Adding additional menu columns and data

Removing an accidental change to config.py ui menu

Cleaning up menu columns, removing description and default_value columns

Added content heading and menu formatting

Fixing shorts showing as null

Cleanup

Starting settings file path work and refining settings stdout

Rebasing????

changes from monday

first pass on tests

Designing tests for settings action

Move into config subsystem

Refining tests for direct interactive ee and no ee tests

Formatting

Adding tests and fixing cli parameter issues in utils

Disable UPDATE_FIXTURES for settings tests

working on stdout test, WIP

fix doc string

test fixes and unit tests

Changing settings to use self._args instead of self.app.args

Linting changes

Additional docstring changes

update_fixtures to false to save CI

fixing stdout stuff

Linter changes

Update _yaml.py

Update _yaml.py

Update settings.py

Unneeded file

Unneeded file

Fixing tests and adding changelog fragment

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update fixtures to false

test fixes

settings unit test fixes (hopefully)

Squashed commit of the following:

commit 38c107f
Author: cidrblock <bthornto@redhat.com>
Date:   Thu Feb 17 10:24:11 2022 -0800

    Mask collection doc cache path

commit c63e830
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit 2ee93ee
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit fe30e46
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit cc3a675
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit e6a6ab3
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit f0fff09
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit 3fec8ae
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

commit c9c28e7
Author: cidrblock <bthornto@redhat.com>
Date:   Wed Dec 1 11:10:15 2021 -0800

    empty

Presentation changes

Update unit tests

REmove curses

readding requirements.yml for builder test_ee

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

stdout test fixes and fixture updates after the last commit

Update docs/changelog-fragments.d/957.internal.md

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

Update docs/changelog-fragments.d/957.internal.md

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

formatting/docstring fixes

Test example for jake

isort

Add constants

Renaming changelog fragment and adding color constants to settings

Refactor utils

cut paste error

Utils updates and variable readability change

Settings updates

Rm commented code, move file

sort

Update definitions.py

Lint fixes, restore type aliases

Switch to TypedDict

Typeddict in 3.8

Format

cast again

TValueType :) all the way through

Switch to DataClass

Unit test fix

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Rebase and update

Fix stdout

Remove duplicate clear

Definitions constants update
@cidrblock cidrblock closed this Mar 11, 2022
@cidrblock cidrblock reopened this Mar 11, 2022
ganeshrn
ganeshrn approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonlhart @thedoubl3j Nice work!
Thanks

@ganeshrn ganeshrn merged commit af5f940 into ansible:main Mar 11, 2022
@cidrblock cidrblock added the enhancement New feature or request label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@cidrblock cidrblock cidrblock approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add settings subcommand
4 participants
@alisonlhart @ganeshrn @cidrblock @thedoubl3j