Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default factory for ApplicationConfiguration #1251

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Default factory for ApplicationConfiguration #1251

merged 1 commit into from
Jul 14, 2022

Conversation

cidrblock
Copy link
Collaborator

Python 3.11 is raising a ValueError because of the mutable default value:

/usr/lib64/python3.11/dataclasses.py:816: in _get_field
    raise ValueError(f'mutable default {type(f.default)} for field '
E   ValueError: mutable default <class 'ansible_navigator.configuration_subsystem.utils.AnsibleConfiguration'> for field ansible_configuration is not allowed: use default_factory

Switch to using default_factory.

@cidrblock cidrblock added bug Researched, reproducible, committed to fix bot:chronographer:skip labels Jul 14, 2022
@cidrblock cidrblock requested a review from ssbarnea July 14, 2022 15:00
@ssbarnea ssbarnea merged commit 79290df into ansible:main Jul 14, 2022
@ssbarnea ssbarnea mentioned this pull request Jul 15, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Researched, reproducible, committed to fix skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cidrblock @ssbarnea