Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint, type] Linting, docstring and type improvements in a*.py files #652

Merged
merged 7 commits into from Dec 8, 2021

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Dec 5, 2021

depends-on: #671

  • does what it says
  • Additionally remove unused function (it got replaced by _argparse_error_handler in configurator long ago)

src/ansible_navigator/app.py Outdated Show resolved Hide resolved
@cidrblock cidrblock added the gate label Dec 8, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit c85bd60 into ansible:main Dec 8, 2021
cidrblock added a commit to cidrblock/ansible-navigator that referenced this pull request Dec 13, 2021
…nsible#652)

[lint, type] Linting, docstring and type improvements in a*.py files

depends-on: ansible#671

does what it says
Additionally remove unused function (it got replaced by _argparse_error_handler in configurator long ago)

Reviewed-by: Rick Elrod <rick@elrod.me>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants