New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lint, type] Linting, docstring and type improvements in a*.py files #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
requested review from
alisonlhart,
thedoubl3j,
a team,
relrod,
ssbarnea and
webknjaz
December 5, 2021 20:58
relrod
reviewed
Dec 6, 2021
webknjaz
reviewed
Dec 8, 2021
cidrblock
force-pushed
the
lint_doc_root_1
branch
from
December 8, 2021 17:38
7665348
to
9c867c1
Compare
webknjaz
reviewed
Dec 8, 2021
webknjaz
approved these changes
Dec 8, 2021
webknjaz
reviewed
Dec 8, 2021
cidrblock
force-pushed
the
lint_doc_root_1
branch
from
December 8, 2021 19:41
bff2d2f
to
7a7c203
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cidrblock
added a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Dec 13, 2021
…nsible#652) [lint, type] Linting, docstring and type improvements in a*.py files depends-on: ansible#671 does what it says Additionally remove unused function (it got replaced by _argparse_error_handler in configurator long ago) Reviewed-by: Rick Elrod <rick@elrod.me> Reviewed-by: Bradley A. Thornton <bthornto@redhat.com> Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends-on: #671