Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh_private_key configuration option #38

Merged
merged 1 commit into from Oct 21, 2019

Conversation

machacekondra
Copy link
Contributor

No description provided.

@machacekondra
Copy link
Contributor Author

cc @mwperina

Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@machacekondra
Copy link
Contributor Author

Hello @pcuzner @jmolmo can you please review/merge if all is OK? Thank you!

@jmolmo
Copy link
Collaborator

jmolmo commented Oct 15, 2019

LGTM

@pcuzner
Copy link
Collaborator

pcuzner commented Oct 16, 2019

@machacekondra sorry for missing the point - but there's no description with this PR. What is it you want to do? Is the goal to provide an override for the ssh key that you embed in the project folder?

@machacekondra
Copy link
Contributor Author

Exactly. In the oVirt project we create the ssh_key on our own and the location is for many versions the same, and we don't want to copy it on other places, we want to have it on single location and so this PR add an option to change the location of the ssh_key.

@pcuzner
Copy link
Collaborator

pcuzner commented Oct 21, 2019

Cool - thanks!

@pcuzner pcuzner merged commit 65ad935 into ansible:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants