Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to specify host port #39

Merged
merged 1 commit into from Oct 22, 2019
Merged

Add support to specify host port #39

merged 1 commit into from Oct 22, 2019

Conversation

machacekondra
Copy link
Contributor

No description provided.

@machacekondra
Copy link
Contributor Author

cc @mwperina

mwperina
mwperina approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@machacekondra
Copy link
Contributor Author

Hello @pcuzner @jmolmo can you please review/merge if all is OK? Thank you!

@jmolmo
Copy link
Collaborator

jmolmo commented Oct 15, 2019

LGTM

pcuzner
pcuzner reviewed Oct 16, 2019
View reviewed changes
Copy link
Collaborator

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the format for the inventory even when port 22 is used. I'd prefer this to be done by exception rather than the default - what do you think?

@machacekondra
Copy link
Contributor Author

Seems reasonable, I will change, thanks.

@machacekondra
Copy link
Contributor Author

@pcuzner done

pcuzner
pcuzner approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcuzner pcuzner merged commit fc2e592 into ansible:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuzner pcuzner pcuzner approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machacekondra @jmolmo @pcuzner @mwperina