Add spec file with systemd unit file #40
Conversation
|
cc @mwperina |
|
As we already commented in previous occasions, to have an spec file implies make decisions about how is going to be deployed the service. For example, using gunicorn, using nginx with TLS mutual auth or not, or other web servers. Use a systemd unit file or not ... I think that is good to have this stuff in the ARS, but is needed to improve our current folder structure and documentation. (To reflect the different possibilities). Can you make the following changes?
|
runner_service/wsgi.py
Outdated
| import runner_service.configuration as configuration | ||
| from runner_service.app import create_app | ||
|
|
||
| """ | ||
| WSGI config for Ansible Runner Service | ||
|
|
||
| It exposes the WSGI callable as a module-level variable named ``application``. | ||
|
|
||
| """ | ||
|
|
||
| # wsgi entry point is only for production servers | ||
| configuration.init(mode='prod') | ||
|
|
||
| # The object to be managed by uwsgi | ||
| application = create_app() |
There was a problem hiding this comment.
Why are you using a different file from the one we have in root folder?
There was a problem hiding this comment.
This one doesn't call setup_common_environment, which is something we don't want in this case.
|
Will do. |
machacekondra
force-pushed
the
packaging
branch
from
aa73f33
to
356f2bc
Compare
|
@jmolmo Thank you for review, I've updated the PR with your comments.. |
|
LGTM |
No description provided.