Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ovirt logrotate patch #74

Merged
merged 4 commits into from Jul 13, 2020
Merged

add ovirt logrotate patch #74

merged 4 commits into from Jul 13, 2020

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Jul 8, 2020 •
edited

issues:

  • when we used logrotate it was not working properly with the filehandler did need to switch to WatchedFileHandler
  • wrong path in ovirt logrotate
  • after rotating the log was missing fixed it by changing nocreate to create
  • removed console output so logs are not put to httpd but only to our logs with our logrotate

@mwperina

@mnecas
Copy link
Contributor Author

mnecas commented Jul 8, 2020 •
edited

I'll do more investigation please don't merge it yet (plus I need to add the patch to spec files)

mwperina
mwperina suggested changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes around logrotate configuration.

Also when new release is added we should remove ansible-runner-service logrotate configuration from engine: https://github.com/oVirt/ovirt-engine/blob/master/packaging/sys-etc/logrotate.d/ovirt-engine.in#L65

misc/packaging/apache/ovirt_log.patch Outdated Show resolved Hide resolved
misc/packaging/apache/ovirt_log.patch Outdated Show resolved Hide resolved
packaging/gunicorn/ovirt_log.patch Outdated Show resolved Hide resolved
packaging/gunicorn/ovirt_log.patch Outdated Show resolved Hide resolved
mwperina
mwperina approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit c5e678b into ansible:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnecas @mwperina