Give more detail when we cannot process a non-JSON streamed line #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
approved these changes
Jan 27, 2023
Akasurde
reviewed
Jan 28, 2023
| @@ -244,8 +244,11 @@ def run(self): | |||
| try: | |||
| line = self._input.readline() | |||
| data = json.loads(line) | |||
| except (json.decoder.JSONDecodeError, IOError): | |||
| self.status_callback({'status': 'error', 'job_explanation': 'Failed to JSON parse a line from worker stream.'}) | |||
| except (json.decoder.JSONDecodeError, IOError) as exc: | |||
There was a problem hiding this comment.
@AlanCoding Thanks for the patch. Could you please add a test for this change?
There was a problem hiding this comment.
Sorry for the delay. I agree.
I just pushed a change where I modified some existing tests. There was effectively already coverage, but I added more detail to the assertions.
Pack the line information into job_explanation for technical reasons Limit line length in these error messages to print to 1000 characters Update tests to check for more error reporting
AlanCoding
force-pushed
the
non_json_error
branch
from
959180e
to
dd4403e
Compare
Shrews
approved these changes
Mar 7, 2023
|
Thanks. Backport PRs are requested ( |
|
Right now I would say "no" to a 2.3 backport. There are a number of error-handling related fixes, and I don't think this would be the most major. |
AlanCoding
added a commit
to AlanCoding/ansible-runner
that referenced
this pull request
Jun 8, 2023
…ible#1186) Pack the line information into job_explanation for technical reasons Limit line length in these error messages to print to 1000 characters Update tests to check for more error reporting
Shrews
pushed a commit
that referenced
this pull request
Jun 13, 2023
…) (#1258) Pack the line information into job_explanation for technical reasons Limit line length in these error messages to print to 1000 characters Update tests to check for more error reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling for this in AWX has been really unforgivably bad. This abuses
result_tracebacksomewhat, but this practice already existed in AWX. More information is better than less, is the main idea I'm following here.