Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to opt-out mounting ~/.ssh inside the execution environment #1194

Open
fridim opened this issue Feb 13, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@fridim
Copy link

fridim commented Feb 13, 2023

Is it possible to prevent ansible-runner from mounting user's ~/.ssh into the container when using EEs?

Looking at https://github.com/ansible/ansible-runner/blob/devel/ansible_runner/utils/__init__.py#L475-L482, it seems it's currently not possible to configure ansible-runner to not mount host ~/.ssh.

Feature request: add a setting and an environment variable to disable mounting ~/.ssh/ entirely.

The documentation in https://ansible-navigator.readthedocs.io/en/latest/faq/#ssh-keys should probably be updated if this feature is implemented.

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Feb 13, 2023
@tonykay
Copy link

tonykay commented Feb 13, 2023

I agree, an option. Our EEs in my opinion do need to default to their "default" or expected behavior but this is a good option IMO.

@gundalow
Copy link
Contributor

@fridim @tonykay Thanks for your comments here.
Would you please be able to detail your setup/use-case here so we can better understand your request? Thanks

@Shrews
Copy link
Contributor

Shrews commented Mar 1, 2023

Per an out-of-band conversation, if a non-SSH connection plugin is being used for node communication, mounting the SSH directory seems useless. I'd be on board with such an enhancement.

@Shrews Shrews added enhancement New feature or request and removed needs_triage New item that needs to be triaged labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants