Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aap 8164 add inventory group list #1514

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Aap 8164 add inventory group list #1514

merged 10 commits into from
Jan 26, 2024

Conversation

matoval
Copy link
Contributor

@matoval matoval commented Jan 25, 2024 •
edited
Loading

Jira ticket: https://issues.redhat.com/browse/AAP-8164

Added Groups List to Group tab in the Invetories page.

Before:
Screenshot from 2024-01-24 13-28-33

After:
image

@matoval matoval marked this pull request as draft January 25, 2024 17:12
@matoval matoval added AWX Label to indicate changes relevant to AWX and removed AWX Label to indicate changes relevant to AWX labels Jan 25, 2024
@github-actions github-actions bot added the CCT Component tests label Jan 25, 2024
@matoval matoval marked this pull request as ready for review January 26, 2024 05:15
AlexSCorey
AlexSCorey requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good work. I have asked some questions, given some food for thought, and requested a few small changes. Really well done. Let me know when its ready for another look. Also might want to ping qe if you haven't done that also

frontend/awx/resources/groups/hooks/useDeleteGroups.tsx Show resolved Hide resolved
frontend/awx/resources/inventories/InventoryGroups/InventoryGroupPage.tsx Outdated Show resolved Hide resolved
frontend/awx/resources/groups/hooks/useGroupsFilters.tsx Show resolved Hide resolved
frontend/awx/resources/inventories/InventoryGroups/InventoryGroupPage.tsx Outdated Show resolved Hide resolved
frontend/awx/resources/inventories/InventoryPage/InventoryGroups.cy.tsx Show resolved Hide resolved
frontend/awx/resources/inventories/hooks/useInventoriesGroupsActions.tsx Show resolved Hide resolved
cypress/fixtures/ad_hoc_commands.json Outdated Show resolved Hide resolved
AlexSCorey
AlexSCorey approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@matoval matoval merged commit 53bf3aa into main Jan 26, 2024
15 checks passed
@matoval matoval deleted the aap-8164_add-inventory-group-list branch January 26, 2024 19:20
@h-kataria h-kataria mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSCorey AlexSCorey AlexSCorey approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX CCT Component tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matoval @AlexSCorey