Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL cleanup #2380

Merged
merged 3 commits into from
May 23, 2024
Merged

URL cleanup #2380

merged 3 commits into from
May 23, 2024

Conversation

keithjgrant
Copy link
Member

  • removes unused :instanceType param from instance group URLs
  • removes unused :resourceType param from role URLs
  • changes underscores in URLs to hyphens for consistency with the rest of the app

Note: after a closer look, I decided the :inventory_type param is still needed in the inventories page, so I left it in place. A constructed inventory can be fetched from the API at /inventories/:id, but using the URL param to fetch from /constructed_inventories/:id instead returns a few extra fields

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing labels May 22, 2024
@keithjgrant keithjgrant force-pushed the 24239-url-cleanup branch 3 times, most recently from 48ab785 to 2a0a81b Compare May 23, 2024 16:14
vidyanambiar
vidyanambiar approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@keithjgrant keithjgrant force-pushed the 24239-url-cleanup branch 5 times, most recently from 79f9f3c to 343d6cc Compare May 23, 2024 20:09
@keithjgrant keithjgrant merged commit ace214a into main May 23, 2024
17 checks passed
@keithjgrant keithjgrant deleted the 24239-url-cleanup branch May 23, 2024 22:42
fullsushidev pushed a commit to fullsushidev/ansible-ui that referenced this pull request Jun 17, 2024
@keithjgrant @fullsushidev
URL cleanup (ansible#2380)
7597238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidyanambiar vidyanambiar vidyanambiar approved these changes

@jamestalton jamestalton Awaiting requested review from jamestalton

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keithjgrant @vidyanambiar