Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-23787]Add tests for workflow job templates #2508

Merged
merged 16 commits into from
Jun 21, 2024

Conversation

daphnemaeve
Copy link
Contributor

Jira issue: https://issues.redhat.com/browse/AAP-23787

Address testing tech debt for workflow job templates page.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Jun 11, 2024
@nixocio nixocio requested a review from skochay330 June 11, 2024 19:14
@daphnemaeve daphnemaeve force-pushed the add-tests-for-workflow-job-templates branch from d533c6c to 3c3e666 Compare June 11, 2024 21:25
@daphnemaeve daphnemaeve marked this pull request as ready for review June 12, 2024 16:30
cypress/e2e/awx/resources/workflowJobTemplates.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/awx/resources/workflowJobTemplates.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/awx/resources/workflowJobTemplates.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/awx/resources/workflowJobTemplates.cy.ts Outdated Show resolved Hide resolved
@daphnemaeve daphnemaeve force-pushed the add-tests-for-workflow-job-templates branch from 67db3bb to 5728b9b Compare June 18, 2024 19:33
@AlexSCorey AlexSCorey changed the title Add tests for workflow job templates [AAP-23787]Add tests for workflow job templates Jun 20, 2024
Copy link
Member

@AlexSCorey AlexSCorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Contributor

@acruzgon acruzgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great job!

@daphnemaeve daphnemaeve merged commit 2263cbd into main Jun 21, 2024
23 checks passed
@daphnemaeve daphnemaeve deleted the add-tests-for-workflow-job-templates branch June 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants