Fixes flake in credentials and some job e2e tests #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AWX
acruzgon
requested changes
Jun 17, 2024
AlexSCorey
force-pushed
the
flakyTestFix
branch
2 times, most recently
from
c22f5b3
to
f6dfcc1
Compare
AlexSCorey
force-pushed
the
flakyTestFix
branch
2 times, most recently
from
46e752d
to
8b22269
Compare
acruzgon
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
following the best practice to avoid creating unused resources, the next two tests are not using the credential created in that describe block:
can display error toast message when running a test from the create credential formcan display success toast message when running a test from the create credential form
i'll leave it up to you. other than that it looks good!
AlexSCorey
force-pushed
the
flakyTestFix
branch
2 times, most recently
from
79c6f75
to
c7f4238
Compare
…jobs delete test to rely on the api a bit less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One goal for this pr, within the jobs tests, is to rely less on the api to finish a job before we can act on it...delete it. To do this I moved some tests out of the e2e test file and into a component test file and to focus less on what the api returns to us, and more on what the user can do. In those tests we assert that a user can delete a job. This is an improvement IMO because we no longer have to wait for the job to finish. We can use stubbed data to load the table with completed jobs, and we can assert that the user can go through the steps necessary to delete a job.