Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topology view tests #2544

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

MilanPospisil
Copy link
Contributor

@MilanPospisil MilanPospisil commented Jun 19, 2024

Flaky test unskipped, but I cant reproduce the failures after many retries...

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Jun 19, 2024
@MilanPospisil MilanPospisil force-pushed the milan_controller_tests_fix_topology_view_6_19 branch 3 times, most recently from dbbb782 to 362111d Compare June 20, 2024 10:42
@MilanPospisil MilanPospisil marked this pull request as ready for review June 20, 2024 11:39
@ZitaNemeckova
Copy link
Member

ZitaNemeckova commented Jun 20, 2024

Gonna re-run it 3 times here and if it's always green I'll approve.

Note: last re-run

@ZitaNemeckova ZitaNemeckova force-pushed the milan_controller_tests_fix_topology_view_6_19 branch from 362111d to 264d9ae Compare June 20, 2024 12:49
@MilanPospisil MilanPospisil marked this pull request as draft June 20, 2024 13:47
@MilanPospisil MilanPospisil force-pushed the milan_controller_tests_fix_topology_view_6_19 branch from 264d9ae to e9da91f Compare June 20, 2024 13:56
@MilanPospisil MilanPospisil force-pushed the milan_controller_tests_fix_topology_view_6_19 branch from e9da91f to b370554 Compare June 21, 2024 08:55
@MilanPospisil MilanPospisil marked this pull request as ready for review June 21, 2024 09:29
@MilanPospisil MilanPospisil merged commit b03ff57 into main Jun 21, 2024
22 of 23 checks passed
@MilanPospisil MilanPospisil deleted the milan_controller_tests_fix_topology_view_6_19 branch June 21, 2024 09:30
RedOrNot pushed a commit that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants