-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-25642] Fix breadcrumbs params in Inventory > Inventory Source > Schedule
details
#2547
Conversation
22da4ae
to
904df53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand the goal here....to add a link in the breadcrumb for the inventory source when on the schedules list inside an inventory source. However, currently if you are on the schedules list inside a resource, we don't use a breadcrumb link for the details view of that resource in other parts of the app. This is because the details view is another tab in line with the details tab. See job templates schedules list as an example below.
Below is an the schedules list inside an inventory source, on this branch. As you can see the breadcrumb links to the inventory source called gergree
, but just clicking on the detail tab takes you to the same place as that link would. If we are going to make this change we should be consistent throughout the app.
Regarding the screenshot on the issue. We can hard code the :inventory_type
param value because only regular inventories have inventory sources....and only inventory sources have schedules.
@AlexSCorey plus I also noticed that breadcrumbs are little different in I'm wondering which breadcrumbs structure should we follow to keep it consistent? CC @tiyiprh @aratti96 |
I think we should follow the pattern in the second image. There was some discussion on this issue and in a PR Vidya worked on before where we decided on the pattern: https://issues.redhat.com/browse/AAP-9170 |
3635d8a
to
98d6015
Compare
98d6015
to
cacd93c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Issue: AAP-25642