Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky tests -> teams #2548

Merged
merged 1 commit into from
Jun 20, 2024
Merged

flaky tests -> teams #2548

merged 1 commit into from
Jun 20, 2024

Conversation

acruzgon
Copy link
Contributor

@acruzgon acruzgon commented Jun 19, 2024 •
edited

This PR is:

  • Adding two additional describe blocks in order to separate tests that are not using resources created during beforeEach
  • Replacing unnecessary filterTableByMultiSelect with filterTableBySingleSelect
  • Removing test can render the team details page because it's a component tests instead of an integration test
  • Removing test can edit a team from the details page because it's a component tests instead of an integration test
  • Removing unnecessary function()
  • Adding new test for bulk deletion

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Jun 19, 2024
vishsanghishetty
vishsanghishetty approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@vishsanghishetty vishsanghishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vishsanghishetty vishsanghishetty merged commit db2bc27 into main Jun 20, 2024
23 checks passed
@vishsanghishetty vishsanghishetty deleted the teams_flaky_tests branch June 20, 2024 12:33
RedOrNot pushed a commit that referenced this pull request Jun 23, 2024
@acruzgon @RedOrNot
flaky tests -> teams (#2548)
8a6644d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishsanghishetty vishsanghishetty vishsanghishetty approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acruzgon @vishsanghishetty