Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-25659] Show error if resources are missing in Schedule wizard #2551

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jerabekjiri
Copy link
Contributor

Screenshot from 2024-06-20 15-25-28

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label Jun 20, 2024
@jerabekjiri jerabekjiri force-pushed the schedule-wizard-missing-resources branch from e543a48 to dba419a Compare June 20, 2024 17:51
@AlexSCorey AlexSCorey self-requested a review June 21, 2024 13:20
Copy link
Member

@marshmalien marshmalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to show an error when a workflow job template is missing an inventory. Only when the launch config inventory_needed_to_start is true AND the schedule is missing an inventory.

https://github.com/ansible/awx/blob/devel/awx/ui/src/components/Schedule/shared/ScheduleForm.js#L246-L260

  let missingInventory = false;
  if (
    launchConfig?.inventory_needed_to_start &&
    !schedule?.summary_fields?.inventory?.id
  ) {
    missingInventory = true;
  }
  return missingInventory;
}, [launchConfig, schedule]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants