-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-25659] Show error if resources are missing in Schedule wizard #2551
Conversation
e543a48
to
dba419a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to show an error when a workflow job template is missing an inventory. Only when the launch config inventory_needed_to_start
is true AND the schedule is missing an inventory.
let missingInventory = false;
if (
launchConfig?.inventory_needed_to_start &&
!schedule?.summary_fields?.inventory?.id
) {
missingInventory = true;
}
return missingInventory;
}, [launchConfig, schedule]);
68d9581
to
b0d714c
Compare
b0d714c
to
8e6056e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!
1fadab0
to
592f61b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we have a difference in error handling for editing a resource with missing dependencies, and creating a schedule on a resource with missing dependencies.
The first image is for editing a schedule that is part of job template hj
.
The second image is for creating a schedule that is part of job template hj
even though the resource name isn't correct (that looks like another bug).
The methods of error handling should be the same in both cases. The in edit scenario we do not show the error message, and we should.
592f61b
to
b412230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the issues I have found are resolved. Looks good to me. Well done!
I file https://issues.redhat.com/browse/AAP-26667 in response to the bug I found about the name of the resource on the review step. |
c882a64
to
4eb0a05
Compare
4eb0a05
to
ad21465
Compare
Issue: AAP-25659
Don't let create schedule if resources are missing
empty state:
![Screenshot from 2024-06-26 14-53-17](https://private-user-images.githubusercontent.com/19647757/343164687-6d225b4d-0927-4c65-98f9-b8c1da4362f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTE2NjUsIm5iZiI6MTcyMTc1MTM2NSwicGF0aCI6Ii8xOTY0Nzc1Ny8zNDMxNjQ2ODctNmQyMjViNGQtMDkyNy00YzY1LTk4ZjktYjhjMWRhNDM2MmYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE2MTYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTliZDhjNjI2MDZjMWI4NDYzYzE0ODEzNjg5M2UwNDQxMDY5MzU1MjI3MDI0OTI3ODU4YjMwNzA3ZjkzNDdiZTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YVmsus1oSdU-aoJf60HPLenhgqC7twDcJ7KVKEPpd2g)
(custom icon requires #2585)disabled button:
![Screenshot from 2024-06-24 16-44-53](https://private-user-images.githubusercontent.com/19647757/343162194-24e5bce7-d4ae-49ea-a941-e25fafe23ec1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTE2NjUsIm5iZiI6MTcyMTc1MTM2NSwicGF0aCI6Ii8xOTY0Nzc1Ny8zNDMxNjIxOTQtMjRlNWJjZTctZDRhZS00OWVhLWE5NDEtZTI1ZmFmZTIzZWMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE2MTYwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzMjA3YmE1Zjc5MTc0YzI4NzJmM2NlNzBkZjQ5YWE2NzRmNDRiMGU4NDZjZGJkN2YyNTNmM2ZkMzE4OWI2OTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.dmjiELyhPl3iisoe93iyuXqNXPzvLRnlpgEdAEseVkU)