Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WorkflowOutputNavigation #2621

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ZitaNemeckova
Copy link
Member

Instead of hardcoded strings use Routes and params

Before/After:
Works the same on the upstream.

Related to https://issues.redhat.com/browse/AAP-25915

@ZitaNemeckova ZitaNemeckova added release-blocker Release Blocker bug Something isn't working labels Jul 1, 2024
@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label Jul 1, 2024
@ZitaNemeckova ZitaNemeckova force-pushed the refactor_job_workflow_output_navigation branch from 7ad14fe to 8ac5864 Compare July 1, 2024 13:39
Instead of hardcoded strings use Routes and params
@ZitaNemeckova ZitaNemeckova force-pushed the refactor_job_workflow_output_navigation branch from 8ac5864 to 54d3193 Compare July 1, 2024 15:15
Copy link
Contributor

@MilanPospisil MilanPospisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MilanPospisil MilanPospisil merged commit 3430fc3 into main Jul 2, 2024
23 checks passed
@MilanPospisil MilanPospisil deleted the refactor_job_workflow_output_navigation branch July 2, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX bug Something isn't working release-blocker Release Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants