-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ansible-test-sanity-docker on f34 #1169
Merged
ansible-zuul
merged 1 commit into
ansible:master
from
goneri:move-ansible-test-sanity-docker-on-f34_18672
Oct 8, 2021
Merged
move ansible-test-sanity-docker on f34 #1169
ansible-zuul
merged 1 commit into
ansible:master
from
goneri:move-ansible-test-sanity-docker-on-f34_18672
Oct 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to Fedora 34 to avoid the reliability issue with Ubuntu kubic repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ansible-zuul bot
pushed a commit
to ansible-collections/community.vmware
that referenced
this pull request
Oct 8, 2021
Fix check-ignores-order Depends-On: ansible/ansible-zuul-jobs#1172 Depends-On: ansible/ansible-zuul-jobs#1169 Depends-On: ansible/ansible-zuul-jobs#1171 SUMMARY check-ignores-order keeps failing ansible-tox-linters in the CI for #1068. I don't know why, I haven't touched anything in tests/sanity/... maybe something new in the CI? ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/sanity/ignore-2.9.txt tests/sanity/ignore-2.10.txt tests/sanity/ignore-2.11.txt tests/sanity/ignore-2.12.txt ADDITIONAL INFORMATION Now: $ LANG=C ./check-ignores-order + tmp_file=/tmp/_sorted_file9578 + trap clean_up EXIT ++ find tests/sanity -name 'ignore-*.txt' + for i in $(find tests/sanity -name 'ignore-*.txt') + sort -u tests/sanity/ignore-2.10.txt + diff -s tests/sanity/ignore-2.10.txt /tmp/_sorted_file9578 Files tests/sanity/ignore-2.10.txt and /tmp/_sorted_file9578 are identical + for i in $(find tests/sanity -name 'ignore-*.txt') + sort -u tests/sanity/ignore-2.13.txt + diff -s tests/sanity/ignore-2.13.txt /tmp/_sorted_file9578 Files tests/sanity/ignore-2.13.txt and /tmp/_sorted_file9578 are identical + for i in $(find tests/sanity -name 'ignore-*.txt') + sort -u tests/sanity/ignore-2.11.txt + diff -s tests/sanity/ignore-2.11.txt /tmp/_sorted_file9578 Files tests/sanity/ignore-2.11.txt and /tmp/_sorted_file9578 are identical + for i in $(find tests/sanity -name 'ignore-*.txt') + sort -u tests/sanity/ignore-2.12.txt + diff -s tests/sanity/ignore-2.12.txt /tmp/_sorted_file9578 Files tests/sanity/ignore-2.12.txt and /tmp/_sorted_file9578 are identical + for i in $(find tests/sanity -name 'ignore-*.txt') + sort -u tests/sanity/ignore-2.9.txt + diff -s tests/sanity/ignore-2.9.txt /tmp/_sorted_file9578 Files tests/sanity/ignore-2.9.txt and /tmp/_sorted_file9578 are identical + clean_up + ARG=0 + rm /tmp/_sorted_file9578 + exit 0 cc @goneri Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
ansible-zuul bot
pushed a commit
to ansible-collections/community.vmware
that referenced
this pull request
Oct 8, 2021
Clean up changelogs/fragments/ Depends-On: ansible/ansible-zuul-jobs#1172 Depends-On: ansible/ansible-zuul-jobs#1169 Depends-On: ansible/ansible-zuul-jobs#1171 Depends-On: #1072 #1062 didn't clean up changelogs/fragments/so I'll do this manually. For now, Id like to do this manually and work on a fix later. I already have an idea... Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: None <None> Reviewed-by: Abhijeet Kasurde <None>
ansible-zuul bot
pushed a commit
to ansible-collections/kubernetes.core
that referenced
this pull request
Oct 15, 2021
[backport/2.2] common/_wait_for: ensure label_selectors is optional (#239) Depends-On: ansible/ansible-zuul-jobs#1170 Depends-On: ansible/ansible-zuul-jobs#1169 Depends-On: ansible/ansible-zuul-jobs#1171 common/_wait_for: ensure label_selectors is optional The label_selectors is a new parameter for _wait_for that was introduced in #158. The value is new and it can be set to None to make it optional. It should not be mandatory a non optional parameter. Reviewed-by: None Reviewed-by: Alina Buzachis Reviewed-by: None (cherry picked from commit 938f7e1) Reviewed-by: None <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to Fedora 34 to avoid the reliability issue with Ubuntu kubic
repository.