Skip to content

Commit

Permalink
Fix invalid src option return response for network config modules (#5…
Browse files Browse the repository at this point in the history
…6076)

*  Add changed key in faliure case to maintain backward compatibility

(cherry picked from commit 1a66121)
  • Loading branch information
ganeshrn authored and mattclay committed May 9, 2019
1 parent e925dd7 commit 457efa8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changelogs/fragments/networkos_config_src_option_fix.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Fix invalid src option return response for network config modules (https://github.com/ansible/ansible/pull/56076)
5 changes: 4 additions & 1 deletion lib/ansible/plugins/action/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ class ActionModule(_ActionModule):
def run(self, task_vars=None):
config_module = hasattr(self, '_config_module') and self._config_module
if config_module and self._task.args.get('src'):
self._handle_src_option()
try:
self._handle_src_option()
except AnsibleError as e:
return {'failed': True, 'msg': e.message, 'changed': False}

result = super(ActionModule, self).run(task_vars=task_vars)

Expand Down

0 comments on commit 457efa8

Please sign in to comment.