win_updates: fix regression when using string cat names (#36015)

ansible · Feb 14, 2018 · 8fb66c1 · 8fb66c1
1 parent 7dfa11c
commit 8fb66c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/ansible/plugins/action/win_updates.py b/lib/ansible/plugins/action/win_updates.py
@@ -6,6 +6,7 @@
 from ansible.errors import AnsibleError
 from ansible.module_utils._text import to_text
 from ansible.module_utils.parsing.convert_bool import boolean
+from ansible.parsing.yaml.objects import AnsibleUnicode
 from ansible.plugins.action import ActionBase
 
 try:
@@ -140,6 +141,9 @@ def run(self, tmp=None, task_vars=None):
             'SecurityUpdates',
             'UpdateRollups',
         ])
+        if isinstance(category_names, AnsibleUnicode):
+            category_names = [cat.strip() for cat in category_names.split(",")]
+
         state = self._task.args.get('state', 'installed')
         reboot = self._task.args.get('reboot', False)
         reboot_timeout = self._task.args.get('reboot_timeout',

diff --git a/test/integration/targets/win_updates/tasks/tests.yml b/test/integration/targets/win_updates/tasks/tests.yml
@@ -43,8 +43,7 @@
 - name: search for updates with log output (check)
   win_updates:
     state: searched
-    category_names:
-    - CriticalUpdates
+    category_names: CriticalUpdates
     log_path: '{{win_updates_dir}}/update.log'
   register: update_search_with_log_check
   check_mode: yes