Skip to content

Commit

Permalink
Add the ansible_2_10 intersphinx reference. (#71028)
Browse files Browse the repository at this point in the history
There are links from the scenario guides to collections but collections
docs aren't built in testing or locally when we're on the devel branch.
Due to that we need to make sure those references resolve to the
production docsite.  We can use intersphinx to make sure that happens.

* The test for binary files wasn't reading enough of the file.

Checking for null bytes in the first 1024 bytes failed to diagnose the
ansible_2_10.inv file as binary
  • Loading branch information
abadger committed Aug 3, 2020
1 parent a6725d6 commit e10902d
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 1 deletion.
Binary file added docs/docsite/ansible_2_10.inv
Binary file not shown.
Binary file modified docs/docsite/ansible_2_8.inv
Binary file not shown.
Binary file modified docs/docsite/ansible_2_9.inv
Binary file not shown.
Binary file modified docs/docsite/python3.inv
Binary file not shown.
1 change: 1 addition & 0 deletions docs/docsite/rst/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@
intersphinx_mapping = {'python': ('https://docs.python.org/2/', (None, '../python2.inv')),
'python3': ('https://docs.python.org/3/', (None, '../python3.inv')),
'jinja2': ('http://jinja.palletsprojects.com/', (None, '../jinja2.inv')),
'ansible_2_10': ('https://docs.ansible.com/ansible/2.10/', (None, '../ansible_2_10.inv')),
'ansible_2_9': ('https://docs.ansible.com/ansible/2.9/', (None, '../ansible_2_9.inv')),
'ansible_2_8': ('https://docs.ansible.com/ansible/2.8/', (None, '../ansible_2_8.inv')),
'ansible_2_7': ('https://docs.ansible.com/ansible/2.7/', (None, '../ansible_2_7.inv')),
Expand Down
2 changes: 1 addition & 1 deletion test/lib/ansible_test/_internal/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ def is_binary_file(path):

with open_binary_file(path) as path_fd:
# noinspection PyTypeChecker
return b'\0' in path_fd.read(1024)
return b'\0' in path_fd.read(2048)


def generate_password():
Expand Down

0 comments on commit e10902d

Please sign in to comment.